Re: [PATCH 1/2] input: touchscreen: add driver for Zeitec ZET6223

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/31/17 at 12:19am, Dmitry Torokhov wrote:
> Hi Jelle,
> 
> On Wed, Jan 18, 2017 at 02:49:46PM -0800, Dmitry Torokhov wrote:
> > On Wed, Jan 18, 2017 at 09:57:14PM +0100, Jelle van der Waa wrote:
> > > > I also have been looking at you previosu submission and had some draft
> > > > changes. I reconciled them in the patch below, if it still works for you
> > > > then I'll fold everything together and apply. Please let me know.
> > > 
> > > I'll find some time to test the patch below, I've one small suggestion
> > > to the patch below.
> 
> It would be very helpful if you let me know if the patch actually works
> on the hardware: the merge window for 4.11 will be opening fairly soon.

Sorry, I had a busy week and at first it didn't work since I didn't have
a regulator and I think the code for the regular might be wrong.

I think that you want the regulators to be optional, but
devm_regulator_get_optional errors out when no vcc/vio is configured.
Changing it to devm_regulator_get makes the driver work. I guess this is
since devm_regulator_get_optional doesn't allow the creation of a dummy
device while devm_regulator_get does.

-- 
Jelle van der Waa
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux