Benjamin Tissoires, on Fri 27 Jan 2017 18:13:15 +0100, wrote: > Better using the defined macros to express the bit masks. > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx> > --- > drivers/tty/vt/keyboard.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c > index 3dd6a49..4a3907e 100644 > --- a/drivers/tty/vt/keyboard.c > +++ b/drivers/tty/vt/keyboard.c > @@ -1044,9 +1044,9 @@ static int kbd_update_leds_helper(struct input_handle *handle, void *data) > unsigned int leds = *(unsigned int *)data; > > if (test_bit(EV_LED, handle->dev->evbit)) { > - input_inject_event(handle, EV_LED, LED_SCROLLL, !!(leds & 0x01)); > - input_inject_event(handle, EV_LED, LED_NUML, !!(leds & 0x02)); > - input_inject_event(handle, EV_LED, LED_CAPSL, !!(leds & 0x04)); > + input_inject_event(handle, EV_LED, LED_SCROLLL, !!(leds & BIT(VC_SCROLLOCK))); > + input_inject_event(handle, EV_LED, LED_NUML, !!(leds & BIT(VC_NUMLOCK))); > + input_inject_event(handle, EV_LED, LED_CAPSL, !!(leds & BIT(VC_CAPSLOCK))); > input_inject_event(handle, EV_SYN, SYN_REPORT, 0); > } > > -- > 2.9.3 > -- Samuel <y> update-menus: relocation error: update-menus: symbol _ZNSt9basic_iosIcSt11char_traitsIcEE4initEPSt15basic_streambufIcS1_E, version GLIBCPP_3.2 not defined in file libstdc++.so.5 with link time reference <y> quoi que ça peut bien vouloir dire ? <D> N a eu la meme merde <y> c ça que ça veut dire ? wow, c'est bien crypté :) -+- #ens-mim s'entraide -+- -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html