Re: [PATCH] HID: wacom: Fix poor prox handling in 'wacom_pl_irq'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 26 Jan 2017, Jason Gerecke wrote:

> Commit 025bcc1 performed cleanup work on the 'wacom_pl_irq' function, making
> it follow the standards used in the rest of the codebase. The change
> unintiontionally allowed the function to send input events from reports
> that are not marked as being in prox. This can cause problems as the
> report values for X, Y, etc. are not guaranteed to be correct. In
> particular, occasionally the tablet will send a report with these values
> set to zero. If such a report is received it can caus an unexpected jump
> in the XY position.
> 
> This patch surrounds more of the processing code with a proximity check,
> preventing these zeroed reports from overwriting the current state. To
> be safe, only the tool type and ABS_MISC events should be reported when
> the pen is marked as being out of prox.
> 
> Fixes: 025bcc1540 ("HID: wacom: Simplify 'wacom_pl_irq'")
> Signed-off-by: Jason Gerecke <jason.gerecke@xxxxxxxxx>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux