Simplify error return if the code returns anyway. Other relevant changes: Drop empty remove function This conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/groeck/coccinelle-patches - Drop empty remove function - Replace 'if (e) return e; return 0;' with 'return e;' Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> --- drivers/input/misc/retu-pwrbutton.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/input/misc/retu-pwrbutton.c b/drivers/input/misc/retu-pwrbutton.c index 30b459b6b344..97d39a965a65 100644 --- a/drivers/input/misc/retu-pwrbutton.c +++ b/drivers/input/misc/retu-pwrbutton.c @@ -69,21 +69,11 @@ static int retu_pwrbutton_probe(struct platform_device *pdev) if (error) return error; - error = input_register_device(idev); - if (error) - return error; - - return 0; -} - -static int retu_pwrbutton_remove(struct platform_device *pdev) -{ - return 0; + return input_register_device(idev); } static struct platform_driver retu_pwrbutton_driver = { .probe = retu_pwrbutton_probe, - .remove = retu_pwrbutton_remove, .driver = { .name = "retu-pwrbutton", }, -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html