Hi Dmitry, > > > +- ledvdd-supply : power supply to the touch key leds > > > > Is this really optional? If yes... how it gets the power when not > > provided? > > Also, is this really a regulator? Given you are testing whether it is on > or off to report LED state it feels to me it might be a GPIO pin, not > regulator... In this case it's a real regulator, not a GPIO. But even if it was a GPIO, I still could use gpio-regulator[*] which handles gpio using the regulator framework. In this case, depending on how the leds are enabled on the DTS, in the driver I would use only one api (regulators indeed) for both the cases. Thanks, Andi [*] Documentation/devicetree/bindings/regulator/gpio-regulator.txt -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html