Hi, > FWIW, I also agree with Chanwoo that the difference is too small to > need a common .dtsi file. in principle I don't like "switching on and off" properties by overwriting them with "status = disable", unless it's really necessary (and this case is not). Even for small differences. It makes the DTS harder to read and duplicates nodes with different values throughout the DTS include chain. In my opinion this approach should be discouraged. Besides, there are other overwritten differences in tm2e.dts that I think should be separated as well. The "common" file approach is widely used in arm/boot/dts/exynos* files. The "status = disable" looks to me more like a temporary hack rather than a permanent solution. In any case, still up to you :) Andi -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
