Hi,
On 31-12-16 18:06, Gregor Riepl wrote:
We could simply make the gpio completely optional by doing:
Then we don't end up ugly-fying the silead.c code...
I remember vaguely that this will make the driver useless in many cases.
Some DSDTs I've seen have ACPI PM functions that handle the GPIO lines, and I tried calling them instead of managing the GPIO directly. This did not appear to work, but maybe I did it wrong.
See here: https://github.com/onitake/gslx680-acpi/blob/master/gslx680_ts_acpi.c#L571
Hmm, I've just written (and deleted) a blurb about how the platform-bus takes
care of power states for us. But this is an i2c driver, so that is not
relevant. For i2c drivers we should indeed do this ourselves. I'll write
a patch based on the code blurb you pointed to and test that on the
2 different model cherrytrail (x86) tablets I've access to.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
