Hi Rob, On Mon, Dec 05, 2016 at 05:42:48PM -0600, Rob Herring wrote: > On Wed, Nov 30, 2016 at 05:21:27PM -0800, Brian Norris wrote: > > From: Caesar Wang <wxt@xxxxxxxxxxxxxx> > > > > Add a compatible string and regulator property for Wacom W9103 > > digitizer. Its VDD supply may need to be enabled before using it. > > > > Signed-off-by: Caesar Wang <wxt@xxxxxxxxxxxxxx> > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > Cc: Jiri Kosina <jikos@xxxxxxxxxx> > > Cc: linux-input@xxxxxxxxxxxxxxx > > Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx> > > --- > > v1 was a few months back. I finally got around to rewriting it based on > > DT binding feedback. > > > > v2: > > * add compatible property for wacom > > * name the regulator property specifically (VDD) > > > > Documentation/devicetree/bindings/input/hid-over-i2c.txt | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > Acked-by: Rob Herring <robh@xxxxxxxxxx> Thanks but (unfortunately) there've been 2 new versions since then. Specifically, Benjamin NACK'ed this patch and requested we NOT include device/manufacturer-specific compatible properties here. In fact, the binding is still rather generic and IMO (and in Benjamin's opinion) doesn't really need to be restricted to a specific device. Please consider reviewing Benjamin's requests and my recent changes. Benjamin has one small remaining comment on v4, and I plan to send the 5th (and final?) version once I'm confident you and Benjamin agree :) Thanks, Brian -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
