Re: [PATCH] HID: change KEY_DATA from 0x275 to 0x277

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/28/2016 10:20 PM, Dmitry Torokhov wrote:
On Mon, Nov 28, 2016 at 12:49:24PM -0800, Ping Cheng wrote:
0x275 is used by KEY_FASTREVERSE. Or, was that on purpose to use
the same value as KEY_FASTREVERSE for KEY_DATA?

Signed-off-by: Ping Cheng <ping.cheng@xxxxxxxxx>

Ugh, that's not good. I guess we should indeed change this and make sure
it goes to stable.

Hans, Kamil, I do not suppose anyone actually been using KEY_DATA as it
would have been clashing with KEY_FASTREVERSE?

No problem. These CEC event defines are only used by the CEC framework which
as of 4.9 is still in staging (will go out of staging in 4.10). So it is no
problem changing this. Nor has anyone been using this.

So:

Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>

Thanks!

	Hans


Thanks.

---
 include/uapi/linux/input-event-codes.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
index d6d071f..3af60ee 100644
--- a/include/uapi/linux/input-event-codes.h
+++ b/include/uapi/linux/input-event-codes.h
@@ -640,7 +640,7 @@
  * Control a data application associated with the currently viewed channel,
  * e.g. teletext or data broadcast application (MHEG, MHP, HbbTV, etc.)
  */
-#define KEY_DATA			0x275
+#define KEY_DATA			0x277

 #define BTN_TRIGGER_HAPPY		0x2c0
 #define BTN_TRIGGER_HAPPY1		0x2c0
--
2.7.4



--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux