Re: [PATCH 0/8] HID: sony: DS4 updates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jiri,

Thanks for merging some of the patches. I will see where the other
discussion is going. Would you be able to merge patch 6 as well, it is
quite standalone adding a new product id?

Thanks,
Roderick

On Mon, Nov 28, 2016 at 5:56 AM, Jiri Kosina <jikos@xxxxxxxxxx> wrote:
> On Wed, 23 Nov 2016, Roderick Colenbrander wrote:
>
>> I would like to share various updates to the DS4 driver. The first
>> 4 patches are bug fixes and improvements discussed in various
>> discussions on linux-input:
>> - Fix issue when mixing USB and Bluetooth due to failure behind
>>   the scens in sony_input_configured. Benjamin suggested the
>>   fix we added.
>> - The touchpad is a separate device to avoid touch influencing
>>   the analog sticks, which happened due to use of input_mt_sync.
>> - The DS4 code now complies to the Linux game controller spec.
>>   We work with SDL2, the biggest DS4 user, to make sure it can
>>   handle the different mappings. If desired we could make the DS3
>>   comply as well and make similar changes.
>> - Make DS4 motion sensors a separate device, so applications
>>   don't have to use 'non-existing' axes. Updated the event code
>>   specs to allow gyroscope data when INPUT_PROP_ACCELEROMETER is
>>   set as suggested by Peter Hutterer.
>>
>> The next 2 patches add the unique ID to the USB device and add
>> support for a new DS4 device.
>>
>> The last 2 patches add calibration and timestamp to the motion
>> sensors, which finally makes the motion sensors usable.
>>
>> As part of the changes we started to wonder if we should drop
>> HID report fixups altogether for the DS4. It is used right now
>> to have the hid-core layer be able to handle events for the
>> 'misbehaving' report ID 17. I'm aware though of various cross
>> platform libraries parsing DS4 HID reports, which are seeing
>> inconsistent views per OS. Not sure what we should do, we could
>> change this in a future patch. We would need to manually report
>> buttons / axes when on Bluetooth for report ID 17.
>
> I've now applied patches 1-3 to for-4.10/sony. For the rest, I'd like to
> still see the discussion of proper interface to take place.
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>



-- 
Roderick Colenbrander
Senior Manager of Software Engineering
Gaikai, a Sony Interactive Entertainment Company
roderick@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux