On Tue, Nov 22, 2016 at 05:51:11PM -0800, Dmitry Torokhov wrote: > On Sun, Nov 20, 2016 at 07:04:02PM +0000, Nick Dyer wrote: > > + /* query 7 */ > > + unsigned char f34_query7_b0:1; > > + unsigned char has_bootloader:1; > > + unsigned char has_device_config:1; > > + unsigned char has_flash_config:1; > > + unsigned char has_manufacturing_block:1; > > + unsigned char has_guest_serialization:1; > > + unsigned char has_global_parameters:1; > > + unsigned char has_core_code:1; > > + unsigned char has_core_config:1; > > + unsigned char has_guest_code:1; > > + unsigned char has_display_config:1; > > + unsigned char f34_query7_b11__15:5; > > + unsigned char f34_query7_b16__23; > > + unsigned char f34_query7_b24__31; > > I see bitfields and I think this is not going to work on big endian > arches because unfortunately they "fill" the bytes with bits in opposite > order. > > We had to rework old Unixsphere code to get rid of bitfields for on-wire > data; this seems to be coming from that code base as well and so needs > to be reworked too. Hi Dmitry- Thanks - that makes sense. I will rework this bit to remove the bitfields. cheers Nick -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
