RE: [PATCH 3/3] hid: intel-ish-hid: ipc: use msleep_interrupt() for wait

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Jiri,

This issue was found by code inspection, no real bug was reported.
Thanks!

Best Regards,
Even Xu

-----Original Message-----
From: Jiri Kosina [mailto:jikos@xxxxxxxxxx] 
Sent: Tuesday, November 15, 2016 9:27 PM
To: Xu, Even <even.xu@xxxxxxxxx>
Cc: linux-input@xxxxxxxxxxxxxxx; Pandruvada, Srinivas <srinivas.pandruvada@xxxxxxxxx>
Subject: Re: [PATCH 3/3] hid: intel-ish-hid: ipc: use msleep_interrupt() for wait

On Fri, 11 Nov 2016, Even Xu wrote:

> set_current_task() must be called before schedule_timeout(), for this 
> driver, in order to avoid incorrect usage, use msleep_interrupt() 
> instead.
> 
> Signed-off-by: Even Xu <even.xu@xxxxxxxxx>

Is this fixing a bug that has been observed / reported in a real life, or has this been found purely via code inspection? (asking to schedule upstream merge properly).

Thanks,

--
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux