On Sun, Nov 06, 2016 at 08:59:34PM +0100, Pali Rohár wrote: > Anyway, I looked into alps.c source code and I see there another > problem with ss4 devices. Function alps_decode_ss4_v2() calls > input_report_*() functions without input_sync(). But all those > input_report_*() should be in alps_process_packet_ss4_v2(). > > Would you like to fix this problem? I think this part actually functions properly as-is because alps_process_packet_ss4_v2() always calls input_sync() after alps_decode_ss4_v2() calls input_report_*(). But I definitely agree this code path is confusing and inconsistent with the rest of alps.c. I'll take another stab at cleaning this up. Thanks, -Paul -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
