On Fri, 4 Nov 2016, Bastien Nocera wrote: > This adds support for the THQ uDraw tablet for the PS3, as > 4 separate device nodes, so that user-space can easily consume > events coming from the hardware. > > Note that the touchpad two-finger support is fairly unreliable, > and a right-click can only be achieved with a two-finger tap > with the two fingers slightly apart (about 1cm should be enough). > > Tested-by: Bastien Nocera <hadess@xxxxxxxxxx> > Signed-off-by: Bastien Nocera <hadess@xxxxxxxxxx> Hi Bastien, overall the driver looks ok to me, thanks. Probably the only concern I'd have -- traditionally, we've always been naming drivers by the vendor, as it turned out that over time they get extended by adding support for multiple devices with the same vendor, and usually there is quite some overlap in shared code. Hence I'd propose to call this driver hid-thq (if that's really the vendor's proper name, doesn't seem to be present in latest usb.ids release). Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
