On 10/18/2016 02:39 PM, Jiri Kosina wrote:
> On Tue, 18 Oct 2016, Jason Gerecke wrote:
>
>>>> if (usage->usage_index + 1 == field->report_count) {
>>>> - if (usage->hid == wacom_wac->features.last_slot_field)
>>>> + if (equivalent_usage == wacom_wac->features.last_slot_field)
>>>
>>> What tree is this based on please? In all the codebase I have,
>>> last_slot_field is a member field of wacom_wac's hid_data, not a member of
>>> struct wacom_features.
>>>
>>
>> This was based on your for-4.9/wacom tree, whose tip (for me) was commit
>> 1924e05 ("HID: wacom - add touch_arbitration parameter to wacom module").
>>
>> It looks like my tree only has commit 601a22f ("HID: wacom: Report input
>> events for each finger on generic devices")
>
> Pardon me? That commit is from 2014 (3.19-rc1). It really shouldn't be
> used as a basis for a development.
>
>> but not commit 003f50a ("HID: wacom: Update last_slot_field during
>> pre_report phase").
>
> That's a commit that went in for 4.9-rc1 (authored by you).
>
>> Not sure why though.
>>
>> What would you like me to do?
>
> Dunno where the confusion is coming from really. Could you please just
> rebase the patchset on top of something up to date (such as or Linus'
> git, master branch in my tree, or whatnot), and resubmit?
>
> Thanks,
>
New v3 patches submitted based on your master branch.
Jason
---
Now instead of four in the eights place /
you’ve got three, ‘Cause you added one /
(That is to say, eight) to the two, /
But you can’t take seven from three, /
So you look at the sixty-fours....
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
