On Thursday 01 September 2016 04:51 PM, Jiri Kosina wrote:
On Wed, 31 Aug 2016, Sudip Mukherjee wrote:
Use proper error code instead of using -1 on failure to allocate
memory. We may use the error code later in the caller.
But we don't. usb_kbd_probe() returns -ENOMEM in case usb_kbd_alloc_mem()
fails anyway, so I fail to see the point of the change really.
Well, yes, we don't as of now.
When I was reading the code for something related to my day job I was a
bit confused with -1 instead of a proper error code. I am sure there
will be many others like me.
Its fine if you think the change is not needed.
regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
