Re: [PATCH v3] input: touchscreen: Remove duplicate ft6236 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Den 06.08.2016 12:00, skrev Hans de Goede:
Hi,

On 06-08-16 04:22, Dmitry Torokhov wrote:
On Fri, Aug 05, 2016 at 05:07:20PM +0200, Stefan Wahren wrote:
Hi Hans,

Am 05.08.2016 um 09:24 schrieb Hans de Goede:
The new(ish) ft6236 simply re-implements the M09 protocol of the
(much) older edt-ft5x06.c driver.

This commit removes this duplicate driver and adds the i2c ids and
dt compatible string to the edt-ft5x06.c driver to keep compatibility.

i think only remove of the driver is incorrect here.

Since there are two similar but still different DT bindings

Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt

Documentation/devicetree/bindings/input/touchscreen/focaltech-ft6236.txt

the DT handling of edt-ft5x06.c needs to be extended and then
finally driver and binding could be removed.

I believe Hans made sure edt-ft5x06.c can handle focaltech-ft6236
bindings. Do you see a discrepancy?

Correct I've double checked that both the i2c protocol and the
reset gpio binding are compatible. Devices using the focaltech-ft6236.txt
binding should work fine with the edt-ft5x06.c driver.

Now if someone can test and confirm that on actual hardware that would be
great...

And we probably want to remove
Documentation/devicetree/bindings/input/touchscreen/focaltech-ft6236.txt
and instead add the compatible string that defines to
Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt

I can whip up a patch for that, but as said some testing on actual
hw would be good, preferably before I write said patch.


I can confirm that this works with a ft6236.
[ 1.987092] input: EP0110M09 as /devices/platform/soc/20804000.i2c/i2c-1/1-0038/input/input0

My display panel is broken, but the values reported by evtest looks correct.
Thanks for doing this, one less driver to care about.

Maybe you could add a reference to touchscreen.txt in edt-ft5x06.txt?


Noralf.

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux