On Tue, Aug 02, 2016 at 06:57:31PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx> > Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx> > --- > drivers/input/touchscreen/ili210x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c > index ddf694b..a8a7089 100644 > --- a/drivers/input/touchscreen/ili210x.c > +++ b/drivers/input/touchscreen/ili210x.c > @@ -169,7 +169,7 @@ static ssize_t ili210x_calibrate(struct device *dev, > > return count; > } > -static DEVICE_ATTR(calibrate, 0644, NULL, ili210x_calibrate); > +static DEVICE_ATTR(calibrate, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, NULL, ili210x_calibrate); Here was a bug in the driver that you helpfully carried over. Since we do not provide "show" method the permissions should be 0200 or S_IWUSR). Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
