On Mon, Jul 25, 2016 at 01:48:25PM -0700, Brian Norris wrote: > On Mon, Jul 25, 2016 at 10:43:13PM +0200, Wolfram Sang wrote: > > On Mon, Jul 25, 2016 at 11:14:10AM -0700, Brian Norris wrote: > > > cros_ec_cmd_xfer returns success status if the command transport > > > completes successfully, but the execution result is incorrectly ignored. > > > In many cases, the execution result is assumed to be successful, leading > > > to ignored errors and operating on uninitialized data. > > > > > > We've recently introduced the cros_ec_cmd_xfer_status() helper to avoid these > > > problems. Let's use it. > > > > > > Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx> > > > > I agree with Dmitry about Thierry pushing the patch. So: > > > > Acked-by: Wolfram Sang <wsa@xxxxxxxxxxxxx> > > Fine with me, as long as Thierry is up for it. > > BTW, I think the dependency is on target for v4.8-rc1, so if Thierry > misses this, then you should be able to apply this yourself after the > merge window. Why the rush? The behaviour of the cros_ec_cmd_xfer() function has not changed in at least a year, so this can't be very urgent. I merged the original patch because it is a dependency for another patch, but given the above I think it's fine if we wait until after v4.8-rc1 and let subsystem maintainers pick them up individually. On another note, the commit message makes it sound like this might fix potential bugs. Since it's been like that for a couple of releases, do we need to Cc: stable@xxxxxxxxxxxxxxx? Thierry
Attachment:
signature.asc
Description: PGP signature
