resume still works here
2016-07-23 12:15 GMT+02:00 Pavel Rojtberg <rojtberg@xxxxxxxxx>:
> If you blame the line, you will see that it was introduced to fix the
> exact problem you are describing.
> Maybe the used USB controller is relevant or something changed in USB
> core meanwhile.
> I will test whether resume works for me without that line as well and
> report back.
>
> Cameron Gutman <aicommander@xxxxxxxxx> schrieb am Sa., 23. Juli 2016
> um 10:27 Uhr:
>>
>> Suspending and resuming the system can sometimes cause the out
>> URB to get hung after a reset_resume. This causes LED setting
>> and force feedback to break on resume. To avoid this, just drop
>> the reset_resume callback so the USB core rebinds xpad to the
>> wireless pads on resume if a reset happened.
>>
>> A nice side effect of this change is the LED ring on wireless
>> controllers is now set correctly on system resume.
>>
>> Signed-off-by: Cameron Gutman <aicommander@xxxxxxxxx>
>> Cc: stable@xxxxxxxxxxxxxxx
>> ---
>> drivers/input/joystick/xpad.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
>> index a529a45..843054a 100644
>> --- a/drivers/input/joystick/xpad.c
>> +++ b/drivers/input/joystick/xpad.c
>> @@ -1626,7 +1626,6 @@ static struct usb_driver xpad_driver = {
>> .disconnect = xpad_disconnect,
>> .suspend = xpad_suspend,
>> .resume = xpad_resume,
>> - .reset_resume = xpad_resume,
>> .id_table = xpad_table,
>> };
>>
>> --
>> 2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
