Re: [PATCH] Input: wacom_w8001 - drop use of ABS_MT_TOOL_TYPE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 14, 2016 at 03:57:59PM +1000, Peter Hutterer wrote:
> On Wed, Jul 13, 2016 at 05:22:30PM -0700, Ping Cheng wrote:
> > On Wednesday, July 13, 2016, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:
> > >
> > > On Mon, Jan 11, 2016 at 12:12 AM, Dmitry Torokhov
> > > <dmitry.torokhov@xxxxxxxxx> wrote:
> > > > On Mon, Jan 11, 2016 at 01:51:51PM +1000, Peter Hutterer wrote:
> > > >> As of e0361b70175f0cd6199dd9ed6679632de73973d4
> > > >>   Input: wacom_w8001 - split the touch and pen devices into two devices
> > > >> the touch events aren't multiplexed over the same device anymore, the use of
> > > >> ABS_MT_TOOL_TYPE is superfluous. And even before then it only ever sent
> > > >> MT_TOOL_TYPE_FINGER anyway.
> > > >>
> > > >> Signed-off-by: Peter Hutterer <peter.hutterer@xxxxxxxxx>
> > > >
> > > > Applied, thank you.
> > >
> > > Hmm, so I applied that but removal of input_mt_report_slot_state()
> > > means that we do not generate tacking IDs for the contacts.
> > 
> > You are right. I have a set of patches to clean up the code. It is
> > still under testing/reviewing...
> > 
> > >
> > > Revert?
> > 
> > It may be quicker to revert this one now. I'll submit the clean up set later.
> 
> yeah, I agree and we found another bug with these devices. It'll be easier
> to merge the fixed set.

OK, reverted (and revert marked for stable). I added your acks to the
revert commit.

Thanks!

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux