Re: [PATCH 4/4] HID: remove ThingM blink(1) driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 21 Jun 2016, Heiner Kallweit wrote:

> Now that support for ThingM blink(1) was merged into the hid-led driver
> the dedicated driver for this device can be removed.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> ---
>  drivers/hid/Kconfig      |  10 --
>  drivers/hid/Makefile     |   1 -
>  drivers/hid/hid-thingm.c | 259 -----------------------------------------------
>  3 files changed, 270 deletions(-)
>  delete mode 100644 drivers/hid/hid-thingm.c
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index ab22090..6b08a3b 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -828,16 +828,6 @@ config HID_TOPSEED
>  	Say Y if you have a TopSeed Cyberlink or BTC Emprex or Conceptronic
>  	CLLRCMCE remote control.
>  
> -config HID_THINGM

Overall the patchset looks good to me. I'd suggest we keep 
CONFIG_HID_THINGM as a stub though, that'd just select CONFIG_HID_LED, so 
that we don't cause kernel config regressions for users who had 
CONFIG_HID_THINGM already turned on.

Also adding Vivien Didelot to CC, as the author of the original driver. 
Vivien, the full set can be found in linux-input archives ( 
http://marc.info/?l=linux-input&r=1&b=201606&w=2 )

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux