RE: [PATCH] Improve Alps HID Touchpad code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,Jiri,

Sorry, I understood.
Actually I don't add line-wrapping, but how do we solve it.

Best Regards,
Masaki Ota
-----Original Message-----
From: 太田 真喜 Masaki Ota 
Sent: Wednesday, June 22, 2016 11:49 AM
To: 'Jiri Kosina'; Dmitry Torokhov
Cc: Masaki Ota; benjamin.tissorires@xxxxxxxxxx; peter.hutterer@xxxxxxxxx; hdegoede@xxxxxxxxxx; linux-input@xxxxxxxxxxxxxxx; 斉藤 直樹 Naoki Saito
Subject: RE: [PATCH] Improve Alps HID Touchpad code

Hi, Jiri,

Sorry, I cannot catch your meaning. What is the part corrupted? 
I added "HID_DEVICE_ID_ALPS_U1_DUAL" instead of " HID_ANY_ID".
Because we want to use our devices except for "HID_DEVICE_ID_ALPS_U1_DUAL" as Mouse mode.

Best Regards,
Masaki Ota
-----Original Message-----
From: Jiri Kosina [mailto:jikos@xxxxxxxxxx]
Sent: Wednesday, June 22, 2016 7:39 AM
To: Dmitry Torokhov
Cc: Masaki Ota; benjamin.tissorires@xxxxxxxxxx; peter.hutterer@xxxxxxxxx; hdegoede@xxxxxxxxxx; linux-input@xxxxxxxxxxxxxxx; 太田 真喜 Masaki Ota; 斉藤 直樹 Naoki Saito
Subject: Re: [PATCH] Improve Alps HID Touchpad code

On Tue, 21 Jun 2016, Dmitry Torokhov wrote:

> > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 
> > 3cdbc4b..678d8bd 100644
> > --- a/drivers/hid/hid-core.c
> > +++ b/drivers/hid/hid-core.c
> > @@ -1772,7 +1772,8 @@ static const struct hid_device_id hid_have_special_driver[] = {
> >  	{ HID_USB_DEVICE(USB_VENDOR_ID_A4TECH, USB_DEVICE_ID_A4TECH_RP_649) },
> >  	{ HID_USB_DEVICE(USB_VENDOR_ID_ACRUX, 0x0802) },
> >  	{ HID_USB_DEVICE(USB_VENDOR_ID_ACRUX, 0xf705) },
> > -	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY, USB_VENDOR_ID_ALPS_JP, HID_ANY_ID) },
> > +	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY, USB_VENDOR_ID_ALPS_JP,
> > +	HID_DEVICE_ID_ALPS_U1_DUAL) },

On top of what Dmitry said, the above has been (corrupted) line-wrapped (most likely by your mail client). Could you please fix that up while fixing the rest of Dmitry's valuable review comments?

Thanks,

--
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux