Hi Dmitry, The modification from Chris is a special case. Because the Touchpad FW is a little different from normal one, It cause problem in Asus's OBE test. That's why Elan's driver use work-around to solve the problem. It's not tested by other touchpad. Let me discuss with internal FW team to confirm the harmless of the patch. B.R KT -----Original Message----- From: Dmitry Torokhov [mailto:dmitry.torokhov@xxxxxxxxx] Sent: Tuesday, June 21, 2016 1:43 AM To: Chris Chiu; kt.liao@xxxxxxxxxx Cc: Charlie Mooney; Michele Curti; Krzysztof Kozlowski; Benson Leung; linux-input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux@xxxxxxxxxxxx Subject: Re: [PATCH] Input: elan_i2c - +200 ms delay before setting to ABS mode On Tue, Jun 07, 2016 at 09:34:09PM +0800, Chris Chiu wrote: > When performing a warm reboot from a system which does not correctly > support ELAN I2C touchpads, the touchpad will sometimes enter standard > mouse mode, cursor then never respond to touchpad event, and making > the driver discard the HID reports and flood dmesg with following > error messages. > "elan_i2c i2c-ELAN1000:00: invalid report id data (1)" > > This change is from ELAN's correction. It needs 200ms delay before > set_mode() so that the mode setting will correctly take effect. KT, is this feasible? > > Signed-off-by: Chris Chiu <chiu@xxxxxxxxxxxx> > --- > drivers/input/mouse/elan_i2c_core.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/input/mouse/elan_i2c_core.c > b/drivers/input/mouse/elan_i2c_core.c > index 2f58985..95080f9 100644 > --- a/drivers/input/mouse/elan_i2c_core.c > +++ b/drivers/input/mouse/elan_i2c_core.c > @@ -210,18 +210,20 @@ static int __elan_initialize(struct elan_tp_data *data) > return error; > } > > - data->mode |= ETP_ENABLE_ABS; > - error = data->ops->set_mode(client, data->mode); > + error = data->ops->sleep_control(client, false); > if (error) { > dev_err(&client->dev, > - "failed to switch to absolute mode: %d\n", error); > + "failed to wake device up: %d\n", error); > return error; > } > > - error = data->ops->sleep_control(client, false); > + msleep(200); > + > + data->mode |= ETP_ENABLE_ABS; > + error = data->ops->set_mode(client, data->mode); > if (error) { > dev_err(&client->dev, > - "failed to wake device up: %d\n", error); > + "failed to switch to absolute mode: %d\n", error); > return error; > } > > -- > 2.1.4 > Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
