On Thu, 16 Jun 2016, Masaki Ota wrote: > From Masaki Ota <masaki.ota@xxxxxxxxxxx> > > <ChangeList> > - Add hid-alps.c for Support Alps I2C HID Touchpad and Stick device. > - Add hid-alps.txt to check this device spec. > - Add Alps-JP vendor ID to hid-idh.h for support this device. > - To build this module, add Alps module definition to Makefile. I have now applied this to hid.git#for-4.8/alps with the following remarks: - the above is, again, not how usual kernel changelog looks like, so I have slightly modified it - struct u1_dev *priv is very internal to the driver, no need for polluting global namespace with 'priv' symbol :) So I've marked it static - I previously asked for clearly documenting the fact that it can't happen to have two physical devices connected to one system (as that'd break the driver as-is), but I don't see that documented anywhere; please submit a followup patch that'd explicitly be stating this in documentation Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
