On Fri, Jun 3, 2016 at 8:40 PM, Andrew Duggan <aduggan@xxxxxxxxxxxxx> wrote: > Signed-off-by: Andrew Duggan <aduggan@xxxxxxxxxxxxx> > +- syna,dribble: Control reporting of dribble packets. Values are 0 for > + default, 1 for explicitly disable, 2 for explicitly enable. > +- syna,palm_detect: Control reporting of the palm detect gesture. Values > + are 0 for default, 1 for explicitly disable, 2 for > + explicitly enable. I think these belong in the device tree, but you should add four bool props instead: syna,dribble-disable; syna,dribble-enable; syna,palm-detect-disable; syna,palm-detect-enable; Those are way easier for the human authoring the device tree to cope with than the opaque parameters. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html