Hi Dmitry- On 01/06/2016 19:17, Dmitry Torokhov wrote: > On Wed, Jun 01, 2016 at 05:39:44PM +0100, Nick Dyer wrote: >> This is a series of patches to add diagnostic data support to the Atmel >> maXTouch driver. It's a rewrite of the previous implementation which output via >> debugfs: it now uses a V4L2 device in a similar way to the sur40 driver. > > I do not have any objections other than some nits form the input side; > majority of the review should come from V4L2 side here... Thanks for the review. I've hopefully fixed the issues you raised and pushed it to https://github.com/ndyer/linux/commits/diagnostic-v4l-20160602 I will wait for the V4L2 folks to comment before posting a [PATCH v4] cheers Nick -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html