On Thursday 26 May 2016 14:19:18 Hans de Goede wrote:
> Hi,
>
> On 26-05-16 11:05, Pali Rohár wrote:
> >On Thursday 26 May 2016 10:55:14 Ben Gamari wrote:
> >>---
> >> drivers/input/mouse/alps.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >>diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> >>index 10e6836..eb4bf31 100644
> >>--- a/drivers/input/mouse/alps.c
> >>+++ b/drivers/input/mouse/alps.c
> >>@@ -143,6 +143,7 @@ static const struct alps_model_info alps_model_data[] = {
> >> { { 0x52, 0x01, 0x14 }, 0x00, { ALPS_PROTO_V2, 0xff, 0xff,
> >> ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED } }, /* Toshiba Tecra A11-11L */
> >> { { 0x73, 0x02, 0x64 }, 0x8a, { ALPS_PROTO_V4, 0x8f, 0x8f, 0 } },
> >>+ { { 0x73, 0x03, 0x28 }, 0x00, { ALPS_PROTO_V8, 0x18, 0x18, ALPS_SS4_V2_ALT_DECODING | ALPS_DUALPOINT } }, /* Dell Latitude E7470 */
> >> };
> >>
> >> static const struct alps_protocol_info alps_v3_protocol_data = {
> >
> >Hi! I would rather move this code into alps_identify and probably create
> >alps_v8_ss<name>_data structure for it.
> >
> >Above alps_model_data list looks like hooks for special touchpads which
> >needs more flags to work correctly...
>
> Agreed, the alps_model_data array is really only used for quirks for old touchpads
> and should not be used for new touchpads.
Ben: Or maybe new structure for alps_identify is not needed at all. Just
set flags based on e7 data (if it has 0x28 or not).
--
Pali Rohár
pali.rohar@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
