On Mon, May 23, 2016 at 5:29 AM, Chris Arges <christopherarges@xxxxxxxxx> wrote:
> This still causes crashes for me unless I also have the patch I submitted
> earlier applied.
Does your device support touch? Your patch would break two-finger
touch since it resets idx before reaches full packet length.
> I'll look at the crashdump in a bit to see what value idx is.
Yes, please get the idx for us. Depends on the actual value, we'll
come up with a solution. I think it will most likely be a specific
workaround for pen if the issue only happens with pen.
Cheers,
Ping
> On Mon, May 23, 2016 at 12:26 AM, Ping Cheng <pinglinux@xxxxxxxxx> wrote:
>>
>> From: wacom <wacom@localhost.localdomain>
>>
>> I guess the patch that added two-finger touch support forgot to update
>> W8001_MAX_LENGTH from 11 to 13.
>>
>> Signed-off-by: Ping Cheng <pingc@xxxxxxxxx>
>> ---
>> drivers/input/touchscreen/wacom_w8001.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/input/touchscreen/wacom_w8001.c
>> b/drivers/input/touchscreen/wacom_w8001.c
>> index bab3c6a..b1b4127 100644
>> --- a/drivers/input/touchscreen/wacom_w8001.c
>> +++ b/drivers/input/touchscreen/wacom_w8001.c
>> @@ -27,7 +27,7 @@ MODULE_AUTHOR("Jaya Kumar <jayakumar.lkml@xxxxxxxxx>");
>> MODULE_DESCRIPTION(DRIVER_DESC);
>> MODULE_LICENSE("GPL");
>>
>> -#define W8001_MAX_LENGTH 11
>> +#define W8001_MAX_LENGTH 13
>> #define W8001_LEAD_MASK 0x80
>> #define W8001_LEAD_BYTE 0x80
>> #define W8001_TAB_MASK 0x40
>> --
>> 1.8.3.1
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
