Re: [PATCH] Input: feed more data into entropy pool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry,

On 05/18/2016 11:32 PM, Dmitry Torokhov wrote:
> Commit 4369c64c79a22 ("Input: Send events one packet at a time")
> significantly reduced amount of entropy input core was feeding to the rest
> of the system, because only the very first event in the event block would
> be used as source of entropy.
> 
> With this change we will be calling add_input_randomness() for every event
> that is not filtered by the input core as a duplicate. In addition, all
> EV_SYN events are ignored.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

Acked-by: Henrik Rydberg <rydberg@xxxxxxxxxxx>

Thanks for this, it has been nagging me as well.

> -	disposition = input_get_disposition(dev, type, code, &value);
> +	if (disposition != INPUT_IGNORE_EVENT && type != EV_SYN)
> +		add_input_randomness(type, code, value);

As a comment, it is not immediately clear to me how this will affect latency,
although it appears rather harmless.

Thanks,
Henrik

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux