Masaki Ota <masaki.ota@xxxxxxxxxxx> writes: > Hi, Ben, > > I would like to submit this modification, but it is not completed yet > Alright. > Attached file is Touchpad device driver code for our I2C HID device. > This device is I2C HID Touchpad + StickPointer. > Fair enough. What about the PS/2 driver? The patch which gave rise to this thread was to drivers/input/mouse/alps.c, which supports devices with PS/2 interfaces. I know for a fact that there are still new devices produced with this hardware (for instance, the Dell Latitude E7470). Do you intend on adding further protocol support for these newer PS/2 devices? > I made the Touchpad code and it can work on Linux. > But StickPointer cannot work.(Actually one device can work, another device cannot work) > > I attached the source code.(Please change .zap -> .zip) > Could you just check this source code? > I'm afraid I can't do a proper review without a proper patch. However, it sounds like your intuition is correct: the device is exposing two physical devices, therefore it should be exposed to the kernel as two input devices. A maintainer would likely be better equipped to provide guidance here, but my guess would be you want to simply allocate a second input device, as is done in the dualpoint codepath in the alps PS/2 driver [1]. Also, note that you will want to clean up the DOS line endings in hid-alps.c before submitting this for review. Cheers, - Ben [1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/input/mouse/alps.c#n2923
Attachment:
signature.asc
Description: PGP signature
