Re: [PATCH v2] hid: thingm: reorder calls in thingm_probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 10 Mar 2016, Heiner Kallweit wrote:

> When reviewing another thingm patch Benjamin Tissoires pointed out
> the following: "The problem here is that hid_hw_start() is called
> before thingm_version() which allows user space to briefly introduce
> races between thingm_version() and any hidraw requests.
> The mutex will not help here as it is initialized after hid_hw_start()
> and only used for protecting the concurrent access of the rgb."
> 
> Avoid this possible issue by calling hid_hw_start() later in the
> probe function.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> ---
> v2:
> - make commit message more verbose

Applied to for-4.6/thingm.

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux