On Fri, Feb 19, 2016 at 11:04:33AM +0100, Geert Uytterhoeven wrote: > At this point in gpio_keys_polled_probe(), button->gpiod contains either > a pointer to a GPIO descriptor or NULL, because: > - gpio_keys_polled_get_devtree_pdata() fills in button->gpiod only if > devm_get_gpiod_from_child() succeeded, > - gpio_to_desc() returns NULL on failure, not an ERR_PTR(), > - button->gpiod is untouched if it was NULL, and button->gpio is not > valid. > > Hence check for NULL only, and return -EINVAL on failure. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
