On Mon, 21 Dec 2015 12:06:50 -0800
Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:
> On Sun, Dec 20, 2015 at 01:49:25PM +0100, Pavel Rojtberg wrote:
> > 2015-12-20 8:55 GMT+01:00 Dmitry Torokhov
> > <dmitry.torokhov@xxxxxxxxx>:
> > > On Sat, Dec 19, 2015 at 10:17:09PM +0100, Clement Calmels wrote:
> > >> On Wed, 16 Dec 2015 14:44:08 -0800
> > >> Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:
> > >>
> > >> > When lighting up the segment identifying wireless controller,
> > >> > Instead of sending command directly to the controller, let's
> > >> > do it via LED API (usinf led_set_brightness) so that LED
> > >> > object state is in sync with controller state and we'll light
> > >> > up the correct segment on resume as well.
> > >> >
> > >> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> > >> > ---
> > >> >
> > >> > I do not have the hardware so please try this out.
> > >> >
> > >> > drivers/input/joystick/xpad.c | 2 +-
> > >> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >> >
> > >> > diff --git a/drivers/input/joystick/xpad.c
> > >> > b/drivers/input/joystick/xpad.c index 36328b3..00a766b 100644
> > >> > --- a/drivers/input/joystick/xpad.c
> > >> > +++ b/drivers/input/joystick/xpad.c
> > >> > @@ -1118,7 +1118,7 @@ static void xpad_send_led_command(struct
> > >> > usb_xpad *xpad, int command) */
> > >> > static void xpad_identify_controller(struct usb_xpad *xpad)
> > >> > {
> > >> > - xpad_send_led_command(xpad, (xpad->pad_nr % 4) + 2);
> > >> > + led_set_brightness(&xpad->led->led_cdev, (xpad->pad_nr % 4)
> > >> > + 2); }
> > >> >
> > >> > static void xpad_led_set(struct led_classdev *led_cdev,
> > >>
> > >> Hi Dimitri,
> > >
> > > Hi Clement,
> > >
> > >>
> > >> My hardware: two wireless xpad 360 using a single usb receiver.
> > >>
> > >> Power on the first gamepad => light the "1" led.
> > >> Power on the second gamepad => light the "2" led.
> > >>
> > >> Suspend the PC (systemctl suspend): the two gamepads are
> > >> "disconnected" => blinking circle.
> > >>
> > >> Resume the PC, the two gamepads keep blinking but are working
> > >> (tested with jstest).
> > >>
> > >> Power off and on the gamepad => still blinking.
> > >> Reload (rmmod/modprobe) the xpad module => still blinking.
> > >>
> > >> That said, without your patch, the behavior is exactly the same.
> > >> It seems that the suspend/resume broke the led feature. Even
> > >> using the /sys/class/leds/xpad0/brigthness sysfs entry does not
> > >> work.
> > >>
> > >
> > > OK, so the patch does work (the device is still correctly
> > > identified), but resume requires additional patches. Could you
> > > try 'xpad' branch of my tree on kernel.org [1] and let me know if
> > > it works for you?
> > at least on my machine your follow up patch was also required which
> > I merged at:
> >
> > with this patch the controllers still continue blinking after
> > resume, however the URB
> > will still work so they respond to subsequent LED commands triggered
> > via sysfs (or if they are powered off and on).
> >
> > I also verified that a LED command is triggered upon resume -
> > however the controller ignores that.
> > Maybe it is sent too early/ in the wrong order.
>
> I wonder if below helps this.
>
Tried this patch above on top https://github.com/paroj/xpad/tree/dtor
branch xpad but this does not help. The leds are still blinking at
resume but at least the sysfs entry is working.
c.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
