Hello, Dmitry,
> > + if (intf->altsetting[0].desc.bNumEndpoints < 1) {
> > + dev_warn(&intf->dev,
>
> This should be dev_err as we are aborting device initialization. I know
> the driver user warn/info in similar places, but it is not right, we
> might want to adjust it at some point.
Yes, the driver using dev_warn() in all the similar error paths was a
reason for me to use dev_warn() here.
> > + err = -ENODEV;
>
> I believe it should be -EINVAL as well. I adjusted the above 3 items
> and applied.
Indeed, this suits best. Thank you for handling this and the issue in
general.
Best regards,
Vladis Dronov | Red Hat, Inc. | Product Security Engineer
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
