Re: drivers/hid/wacom_wac.c:2484: bad if test ?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 16 Nov 2015, David Binderman wrote:

> Hello there,
> 
> drivers/hid/wacom_wac.c:2484:35: warning: logical ‘or’ of collectively 
> exhaustive tests is always true [-Wlogical-op]
> 
> Source code is
> 
> if (features->type>= INTUOSHT || features->type <= BAMBOO_PT)

Good catch, that code is obviously crappy.

Adding Ping, Aaron and Jason to CC.

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux