----- Original Message -----
> From: "Elias Vanderstuyft" <elias.vds@xxxxxxxxx>
> To: "Benjamin Tissoires" <benjamin.tissoires@xxxxxxxxxx>
> Cc: "Dmitry Torokhov" <dmitry.torokhov@xxxxxxxxx>, "David Herrmann" <dh.herrmann@xxxxxxxxx>, "Peter Hutterer"
> <peter.hutterer@xxxxxxxxx>, "open list:HID CORE LAYER" <linux-input@xxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
> Sent: Sunday, November 8, 2015 11:55:04 AM
> Subject: Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl
>
> Hi,
>
> On Tue, Aug 25, 2015 at 5:12 PM, Benjamin Tissoires
> <benjamin.tissoires@xxxxxxxxxx> wrote:
> > diff --git a/include/uapi/linux/uinput.h b/include/uapi/linux/uinput.h
> > index 013c9d8..ef6c9f5 100644
> > --- a/include/uapi/linux/uinput.h
> > +++ b/include/uapi/linux/uinput.h
> > @@ -20,6 +20,11 @@
> > * Author: Aristeu Sergio Rozanski Filho <aris@xxxxxxxxxxxxxxxxx>
> > *
> > * Changes/Revisions:
> > + * 0.5 08/13/2015 (David Herrmann <dh.herrmann@xxxxxxxxx> &
> > + * Benjamin Tissoires
> > <benjamin.tissoires@xxxxxxxxxx>)
> > + * - add UI_DEV_SETUP ioctl
> > + * - add UI_ABS_SETUP ioctl
> > + * - add UI_GET_VERSION ioctl
> > * 0.4 01/09/2014 (Benjamin Tissoires
> > <benjamin.tissoires@xxxxxxxxxx>)
> > * - add UI_GET_SYSNAME ioctl
> > * 0.3 24/05/2006 (Anssi Hannula <anssi.hannulagmail.com>)
> > @@ -37,8 +42,8 @@
> > #include <linux/types.h>
> > #include <linux/input.h>
> >
> > -#define UINPUT_VERSION 4
> > -
> > +#define UINPUT_VERSION 5
> > +#define UINPUT_MAX_NAME_SIZE 80
> >
> > struct uinput_ff_upload {
> > __u32 request_id;
> > @@ -58,6 +63,79 @@ struct uinput_ff_erase {
> > #define UI_DEV_CREATE _IO(UINPUT_IOCTL_BASE, 1)
> > #define UI_DEV_DESTROY _IO(UINPUT_IOCTL_BASE, 2)
> >
> > +struct uinput_setup {
> > + struct input_id id;
> > + char name[UINPUT_MAX_NAME_SIZE];
> > + __u32 ff_effects_max;
> > +};
>
> Is there a reason to not follow the same field order as in struct
> uinput_user_dev?
Not really, no.
> I.e., why not:
>
> struct uinput_setup {
> char name[UINPUT_MAX_NAME_SIZE];
> struct input_id id;
> __u32 ff_effects_max;
> };
>
> In case you would change this, also make sure to change the order in
> the documentation of UI_DEV_SETUP.
>
Works for me.
Dmitry, how do you want to handle this change? Me re-sending the whole series or you applying the change directly on your tree?
Cheers,
Benjamin
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
