[PATCH] Input: improve autorepeat initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Allow driver to initialize only input_dev->rep[REP_DELAY] and
input_dev->rep[REP_PERIOD], but then use the input timer and
repeat function from input.c.

For example, a HID driver could do:

static void xyz_input_configured(struct hid_device *hid,
                                 struct hid_input *hidinput)
{
        hidinput->input->rep[REP_DELAY] = 400;
        hidinput->input->rep[REP_PERIOD] = 100;
}

static struct hid_driver xyz_driver = {
        .input_configured = xyz_input_configured,
}

Signed-off-by: Petri Gynther <pgynther@xxxxxxxxxx>
---
 drivers/input/input.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/input/input.c b/drivers/input/input.c
index 5391abd..1984ba5 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -2115,6 +2115,15 @@ int input_register_device(struct input_dev *dev)
 		dev->rep[REP_PERIOD] = 33;
 	}
 
+	/*
+	 * If the driver didn't initialize the timer data and function, then
+	 * handle the autorepeating here in input.c.
+	 */
+	if (!dev->timer.data && !dev->timer.function) {
+		dev->timer.data = (unsigned long) dev;
+		dev->timer.function = input_repeat_key;
+	}
+
 	if (!dev->getkeycode)
 		dev->getkeycode = input_default_getkeycode;
 
-- 
2.6.0.rc2.230.g3dd15c0

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux