Hello Dmitry, On 10/02/2015 08:25 PM, Dmitry Torokhov wrote: > Hi Javier, > > On Fri, Oct 02, 2015 at 03:40:11PM +0200, Javier Martinez Canillas wrote: >> Hello Dmitry, >> >> This series contains trivial patches with fixes to different warnings >> reported by make coccichek M=drivers/input. >> >> The patches don't contain functional changes but makes the functions >> simpler and removes unnecessary lines of code. > > I disagree with some "simplify function return logic" patches: when > there are several actions that may fail I prefer explicit: > > error = actionN(); > if (error) > return error; > > return 0; > > even on the last one as it keep with the code flow and makes it easier > to move stuff around. > > Please consider patches that not explicitly replied to as applied a > dropped. Thanks a lot for taking the time to explain this. I understand your rationale and I tend to agree. I'll see if the scripts/coccinelle/misc/simple_return.cocci semantic patch can be modified to take this into account and not report a warning for that pattern. > > Thanks. > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
