On Fri, Oct 02, 2015 at 03:40:26PM +0200, Javier Martinez Canillas wrote: > The invoked function already returns zero on success or a negative > errno code so there is no need to open code the logic in the caller. > > This also fixes the following make coccicheck warnings: > > end returns can be simplified and declaration on line 402 can be dropped > > Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> Applied, thank you. > --- > > drivers/input/touchscreen/auo-pixcir-ts.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/input/touchscreen/auo-pixcir-ts.c b/drivers/input/touchscreen/auo-pixcir-ts.c > index 38c06f754acd..6592fc5d48b4 100644 > --- a/drivers/input/touchscreen/auo-pixcir-ts.c > +++ b/drivers/input/touchscreen/auo-pixcir-ts.c > @@ -399,13 +399,8 @@ static int auo_pixcir_stop(struct auo_pixcir_ts *ts) > static int auo_pixcir_input_open(struct input_dev *dev) > { > struct auo_pixcir_ts *ts = input_get_drvdata(dev); > - int ret; > - > - ret = auo_pixcir_start(ts); > - if (ret) > - return ret; > > - return 0; > + return auo_pixcir_start(ts); > } > > static void auo_pixcir_input_close(struct input_dev *dev) > -- > 2.4.3 > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html