On Fri, Oct 02, 2015 at 03:54:51PM +0200, Heiko Stübner wrote:
> Am Freitag, 2. Oktober 2015, 15:40:17 schrieb Javier Martinez Canillas:
> > The invoked function already returns zero on success or a negative
> > errno code so there is no need to open code the logic in the caller.
> >
> > This also fixes the following make coccicheck warning:
> >
> > end returns can be simplified and declaration on line 602 can be dropped
> >
> > Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>
> I wonder what let me make that decision ... probably copy'n'paste from my auo-
> pixcir driver ... but how that got into this one is still a mystery to me ;-)
> anyway
>
> Reviewed-by: Heiko Stuebner <heiko.stuebner@xxxxxx>
Applied, thank you.
>
>
> > ---
> >
> > drivers/input/touchscreen/zforce_ts.c | 7 +------
> > 1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/drivers/input/touchscreen/zforce_ts.c
> > b/drivers/input/touchscreen/zforce_ts.c index 781d0f83050a..9bbadaaf6bc3
> > 100644
> > --- a/drivers/input/touchscreen/zforce_ts.c
> > +++ b/drivers/input/touchscreen/zforce_ts.c
> > @@ -599,13 +599,8 @@ static irqreturn_t zforce_irq_thread(int irq, void
> > *dev_id) static int zforce_input_open(struct input_dev *dev)
> > {
> > struct zforce_ts *ts = input_get_drvdata(dev);
> > - int ret;
> >
> > - ret = zforce_start(ts);
> > - if (ret)
> > - return ret;
> > -
> > - return 0;
> > + return zforce_start(ts);
> > }
> >
> > static void zforce_input_close(struct input_dev *dev)
>
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
