The invoked function already returns zero on success or a negative errno code so there is no need to open code the logic in the caller. This also fixes the following make coccicheck warning: drivers/input/touchscreen/jornada720_ts.c:137:1-6: WARNING: end returns can be simplified Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> --- drivers/input/touchscreen/jornada720_ts.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/input/touchscreen/jornada720_ts.c b/drivers/input/touchscreen/jornada720_ts.c index ea3b6a5b83e6..177a1e92da03 100644 --- a/drivers/input/touchscreen/jornada720_ts.c +++ b/drivers/input/touchscreen/jornada720_ts.c @@ -134,11 +134,7 @@ static int jornada720_ts_probe(struct platform_device *pdev) return error; } - error = input_register_device(jornada_ts->dev); - if (error) - return error; - - return 0; + return input_register_device(jornada_ts->dev); } /* work with hotplug and coldplug */ -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
