[re-adding the lists, I went off-list to clarify] On Fri, Sep 18, 2015 at 9:12 AM, Daniel Martin <consume.noise@xxxxxxxxx> wrote: > On 18 September 2015 at 13:54, Benjamin Tissoires > <benjamin.tissoires@xxxxxxxxx> wrote: >> On Fri, Sep 18, 2015 at 7:50 AM, Daniel Martin <consume.noise@xxxxxxxxx> wrote: >>> What's the problem with last minute fixes, which look so simple that >>> they can't cause any harm? >>> ... This patch is discarded! :/ >> >> Either I am missing something, either you misinterpret me. I never >> said that your patch should be discarded. >> >> Could you elaborate a little bit more (by setting the context) please? > > With this patch (including my last minute changes) we may end up with > stuck ghost touches. > > - We have to increase num_received in mt_complete_slot() if we see and > skip a suspicious contact. Otherwise we don't send the sync report > when necessary. Atm. we just return. > - But, then I noticed that even this is not sufficient. I had to add > MT_QUIRK_NOT_SEEN_MEANS_UP. Which bugs me, cause the reports looked > okay - I always saw a tipswitch=0. Either I didn't saw it or there's > another problem in the slot number computation. > > For now, I'm going home and take some homework with me. > > Cheers, > Daniel > > PS: With my last minute changes I removed an obvious facepalm, which > looked okay at the beginning, though ... > slotnum = contactid % maxcontacts can't be right. ;) OK thanks for the explanations. Jiri, please note not to pull this one :) Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
