On Sun, Sep 13, 2015 at 12:31 PM, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > On Sat, Sep 12, 2015 at 10:08 PM, Vaishali Thakkar > <vthakkar1994@xxxxxxxxx> wrote: >> On Sat, Sep 12, 2015 at 11:52 PM, Dmitry Torokhov >> <dmitry.torokhov@xxxxxxxxx> wrote: >>> On Sat, Sep 12, 2015 at 08:26:18PM +0530, Vaishali Thakkar wrote: >>>> Use managed resource functions devm_request_threaded_irq, >>>> devm_inpute_allocate_device and devm_kzalloc to simplify >>>> error handling. Also, remove use of input_unregister_device >>>> as input_register_device itself handles it and works as >>>> resource managed function. >>>> >>>> To be compatible with the change, various gotos are replaced >>>> with direct returns, and unneeded labels are dropped. With >>>> these changes remove ad714x_remove and corresponding calls of >>>> it as they are now redundant. >>>> >>>> Signed-off-by: Vaishali Thakkar <vthakkar1994@xxxxxxxxx> >>>> --- >>>> Please note that this patch is having three lines over 80 >>>> characters as limiting them to 80 characters makes code >>>> less readable. >>> >>> You can actually remove input[input_alloc] and that will allow you to >>> stay witing 80 columnts. Does the following version still work for you? >> >> Sure. This makes perfect sense. Thanks. >> >> Can I send v2 of a patch with all changes you suggested or would you >> like me to split this patch in 2 patches? > > If the version I sent works for you there is no need to resend/splt. Yeah, Ok. That works for me. > Thanks. > > -- > Dmitry -- Vaishali -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
