On Friday, September 11, 2015 11:10 AM, Fabio Estevam wrote: > On Fri, Sep 11, 2015 at 12:02 AM, WEN Pingbo <pingbo.wen@xxxxxxxxxx> wrote: > >> - clk_enable(psif->pclk); >> + retval = clk_enable(psif->pclk); >> + if (retval < 0) >> + dev_err(&psif->pdev->dev, >> + "could not enable pclk, ret %d\n", retval); > Shouldn't you add a 'return' here to prevent the code to proceed with > the failed clock? Yes, it should be there. I will re-send the patch. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html