Hi Dmitry, 2015-08-29 9:45 GMT+09:00 Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>: > Hi Yoichi, > > On Fri, Aug 07, 2015 at 06:06:14PM +0900, Yoichi Yuasa wrote: >> v5 Changes: >> - contact count variables move to array >> - remove unneeded u16 casts in #define >> - remove module parameters >> - handle "no fingers" as same as others >> - move devm_request_thread_irq() from open() to probe() >> - move "power off" from remove() to close() > > You must have sent me some interim version because it could not have > worked for you. For example, you pass 'ts' pointer to > devm_request_theraded_irq() before allocating memory for ts, you also > treat sysfs attributes as if they were attached to input device > structure while you are creating them (as you should) at i2c dveice > level. I'm sorry, I sent the wrong version. > Also, handling of sysfs attributes is racy with regard to open/close. I > tried correcting these issues (and also made some stylistic changes, > please see an incremental patch below). If you could integrate it with > your work and test to make sure it actually works with the hardware that > would be great. I'll check your patch and I'll update my patch soon. Thanks a lot, Yoichi -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
