Re: [PATCH 2/6] input: pwm-beeper: Fix module autoload for OF platform driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Luis,

On Thu, Aug 27, 2015 at 9:59 AM, Luis de Bethencourt
<luis@xxxxxxxxxxxxxxxxx> wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luis@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/input/misc/pwm-beeper.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
> index e82edf8..a02b9a4 100644
> --- a/drivers/input/misc/pwm-beeper.c
> +++ b/drivers/input/misc/pwm-beeper.c
> @@ -175,6 +175,8 @@ static const struct of_device_id pwm_beeper_match[] = {
>  };
>  #endif
>
> +MODULE_DEVICE_TABLE(of, pwm_beeper_match);
> +

I'm fairly certain this (ano others) blow up in case of !CONFIG_OF.
Please bring MODULE_DEVICE_TABLE into #ifdef block above.

>  static struct platform_driver pwm_beeper_driver = {
>         .probe  = pwm_beeper_probe,
>         .remove = pwm_beeper_remove,
> --
> 2.4.6
>

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux