On Sun, Aug 23, 2015 at 02:11:20AM +0200, Julia Lawall wrote: > Propagate error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > identifier ret; expression e1,e2; > @@ > ( > if (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> Applied, thank you. > > --- > drivers/input/touchscreen/sur40.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c > index 8be7b9b..3f11763 100644 > --- a/drivers/input/touchscreen/sur40.c > +++ b/drivers/input/touchscreen/sur40.c > @@ -581,6 +581,7 @@ static int sur40_probe(struct usb_interface *interface, > sur40->alloc_ctx = vb2_dma_sg_init_ctx(sur40->dev); > if (IS_ERR(sur40->alloc_ctx)) { > dev_err(sur40->dev, "Can't allocate buffer context"); > + error = PTR_ERR(sur40->alloc_ctx); > goto err_unreg_v4l2; > } > > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
