Re: [PATCH v3 1/1] cap11xx: add runtime PM support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ah of course would have to be allocated before the leds and input device register. 

Sent from my iPhone

> On Aug 21, 2015, at 09:35, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote:
> 
>> On Thu, Aug 20, 2015 at 07:07:28PM -0700, Matt Ranostay wrote:
>> On Thu, Aug 20, 2015 at 5:37 PM, Dmitry Torokhov
>> <dmitry.torokhov@xxxxxxxxx> wrote:
>>> Hi Matt,
>>> 
>>>> On Tue, Aug 18, 2015 at 06:21:29PM -0700, Matt Ranostay wrote:
>>>> 
>>>> +static int cap11xx_i2c_remove(struct i2c_client *i2c_client)
>>>> +{
>>>> +     struct cap11xx_priv *priv = i2c_get_clientdata(i2c_client);
>>>> +
>>>> +     cap11xx_set_sleep(priv, true);
>>>> +     pm_runtime_disable(&i2c_client->dev);
>>>> +     pm_runtime_set_suspended(&i2c_client->dev);
>>> 
>>> As I mentioned in my previous review:
>> 
>> Ok that makes sense. What would be the correct way to do this with
>> that in mind?
> 
> Maybe try installing a custom devm actioni (devm_add_action)? You want
> to ensure that the device is put to sleep only after unregistering input
> and LED devices.
> 
> Thanks.
> 
> -- 
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux