Re: [PATCH v2] drivers/hid: Check result of debugfs_create_dir() and debugfs_create_file()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Jiri,

On 08-19-15, Jiri Kosina wrote:
> On Wed, 19 Aug 2015, Alexander Kuleshov wrote:
> 
> >  
> > -	hid_debug_init();
> > +	if (hid_debug)
> > +		hid_debug_init();
> 
> How is this change related to the rest of the patch?
> 
> It's wrong anyway, because hid_debug is independent of the debugfs HID 
> debugging facility. Please see for example the printk() a few lines above 
> in this very function, which is emited in case hid_debug is enabled.
>

hmm, I thought that these things are related. I've remove all hid_debug check
and sent v3 of the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux